Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected change from v1: missing dragElement should result in non-sortable item #462

Open
runspired opened this issue Jan 21, 2022 · 2 comments

Comments

@runspired
Copy link

in v1 if a sortable-item specified a selector for the dragElement, and no such element existed, the item would be unsortable.
in v3 these items become sortable by dragging the main element.

@MelSumner
Copy link
Contributor

@runspired was this a documented breaking change, or is it a bug?

@runspired
Copy link
Author

runspired commented Feb 7, 2022

@MelSumner it was not documented, so it's likely a bug.

That said the old behavior was a bit "odd" in that there was never support for rending with/without a drag handler available via selector and then later having that change in a new render post-initialization. In our app I migrated us to using the disabled attributes, which is a much simpler path forward for this case than having us do a difficult re-check of the DOM on each update. It might be worthwhile to simply document this as a breaking-change retroactively and mention the solution as being to use the disabled arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants