Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor: col-resize for lt-column-resizer #480

Closed
Techn1x opened this issue Sep 18, 2017 · 5 comments
Closed

cursor: col-resize for lt-column-resizer #480

Techn1x opened this issue Sep 18, 2017 · 5 comments

Comments

@Techn1x
Copy link

Techn1x commented Sep 18, 2017

Currently it seems to be getting a cursor: pointer; applied to it, which isn't as UX friendly as a proper resize cursor is.

I've applied my own style to .lt-column-resizer to add the cursor: col-resize and it seems fine. I might get a chance to do a PR for it this week before I go on holiday, but if someone else beats me to it that would be great ;)

@buschtoens
Copy link
Collaborator

In theory that should already be the case. 🤔

@Techn1x
Copy link
Author

Techn1x commented Sep 18, 2017

Ah I see. Looking at the Resizable Columns Table demo, the tag looks like this

<div id="ember980" class="lt-column-resizer ember-view">
</div>

This works as expected, the resizable cursor is used.


Looking at my own webapp, it seems there is a cursor:pointer; applied to the style attribute of the element, and that overrides the resizable cursor set in the class

<div style="touch-action: manipulation;-ms-touch-action: manipulation; cursor: pointer;" id="ember1757" class="lt-column-resizer ember-view">
</div>

I'm not sure how or why those style attributes are there... is it anything to do with ELT? Or should I be looking elsewhere?

@buschtoens
Copy link
Collaborator

Do you have ember-hammertime installed by any chance? I would assume that it accidentally adds these styles: Using Touch-action as a fastclick

@Techn1x
Copy link
Author

Techn1x commented Sep 18, 2017

Looks like I do! It was installed as a dependency for ember-toggle. Now to figure out how to make it work nicely with ELT... :)

@Techn1x
Copy link
Author

Techn1x commented Jan 6, 2018

Closing this because it's a pretty niche issue and isn't really to do with ELT. Thanks for the tip about ember-hammertime

For anyone else reading this, there is more discussion here html-next/ember-hammertime#31

@Techn1x Techn1x closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants