Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ember Auto Import without requiring manual configuration #159

Open
jelhan opened this issue Nov 15, 2020 · 0 comments
Open

Support Ember Auto Import without requiring manual configuration #159

jelhan opened this issue Nov 15, 2020 · 0 comments

Comments

@jelhan
Copy link
Collaborator

jelhan commented Nov 15, 2020

Ember Auto Import is a default dependency of new Ember applications and addons. It violates default CSP by default. Its configuration must be adjusted manually to be compatible with Ember CLI Content Security Policy. It is documented both in our documentation as well as in Ember Auto Import's documentation. While that documentation helps new adopters to resolve the issue it's still a terrible developer experience. We should provide compatibility out of the box.

Ember Auto Import is uninstalled in the test suite to not cause tests to fail. As soon as both addons are compatible by default this code should be removed. After that point the existing tests will also provide regression tests that a new project does not violate the default CSP. https://github.com/rwjblue/ember-cli-content-security-policy/blob/8c4067ada6c8a0a93106d0a2e08acd5c490329bd/node-tests/e2e/test-support-test.js#L25-L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant