New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usePersistedQueries.js optimization #95

Open

jihuang-adobe opened this issue Nov 29, 2023 · 0 comments

Contributor

jihuang-adobe commented Nov 29, 2023

Expected Behavior

graphql endpoint namespace should be defined in .env like REACT_APP_HOST_URI

Actual Behavior

graphql endpoint namespace is hardcoded multiple times within usePersistedQueries.js

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

please search for wknd-shared in
https://github.com/adobe/aem-guides-wknd-graphql/blob/main/react-app/src/api/usePersistedQueries.js

Logs taken while reproducing problem

jihuang-adobe mentioned this issue

Parameterized graphql endpoint and caching #96

Merged

10 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment