-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let workspace build on arm64 / M1 macs #313
Comments
What does work, however: Download an x86_64 JDK, for example: Open terminal (e.g. in Idea) |
Currently still fails without rosetta compatibility mode, see ticket. Fixes #313
Ideally, we'd find a Docker image including Java that is available for both x86_64 and amd64, so we can build on both architectures, and also publish for both architectures. Technically, that's possible. |
Currently still fails without rosetta compatibility mode, see ticket. Fixes #313
Just pushed the nonsense JDK17 JavaDoc fixes to |
Seems like this is the underlying issue: |
This image is available in multiple architectures, i.e. arm64 and x86_64 Fixs #313
This image is available in multiple architectures, i.e. arm64 and x86_64 Fixs #313
Must have been blind when I looked yesterday - the official openjdk is indeed available in a lot of architectures: This does not solve the "docker buildx" problem where we want to build both x86_64 and arm64 compatible Docker images on one architecture. |
This image is available in multiple architectures, i.e. arm64 and x86_64 Also create minimal JRE to use in final image. Fixs #313
Yet another iteration on the Dockerfile - the official alpine image is now extremely small, ~2.5MB. Current S3Mock: ~91MB Confirmed on both M1 and Intel MacBook that the proposed Docker image built is working on the platform it's being built on. Since Github Actions is using x86_64 as an architecture, the published Docker image will still be "amd64" only. |
It's possible to build ARM64 images on GitHub Actions, example: - name: Set up QEMU
uses: docker/[email protected]
- name: Set up Docker Buildx
uses: docker/[email protected]
with:
version: v0.6.0
buildkitd-flags: --debug
- name: Login to DockerHub
uses: docker/[email protected]
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
- name: Build and push
uses: docker/[email protected]
with:
file: etc/Dockerfile
context: .
platforms: linux/amd64,linux/arm64
push: true
tags: s3mock/tag |
@ruudk thanks, the main problem right now is that we use the docker-maven-plugin to both build and publish the Docker container.
I may end up removing the |
merged #333 today, and now at least I can build |
see last comment, we're good here for now. At least I can build the S3Mock locally and run all IntegrationTests. |
@afranken Is there any plan to release multi-arch docker image? |
@dlsrb6342 yes, the plan is still to release a multi-arch image, but as detailed here: #313 (comment) we're currently relying on the docker-maven-plugin which still does not support multi-arch builds or releases. You could right now check out this GIT repo and run the build locally. |
just released version |
Finally got my M1.
We knew that the Docker container we publish is x86_64 only, which we intend to fix.
Now I see that this workspace does not even build on arm64...
Seems like fabric8 maven plugin bundles some native x86_64 dependencies.
The text was updated successfully, but these errors were encountered: