Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed does not seem to actually embed #122

Open
RightFootConsulting opened this issue Jan 3, 2024 · 1 comment
Open

Embed does not seem to actually embed #122

RightFootConsulting opened this issue Jan 3, 2024 · 1 comment

Comments

@RightFootConsulting
Copy link

I am testing out the project with a build built on the windows command line. I have moved the binary copy of my forked version which fixes another issue with the sysprocattr not working in windows, and that is out for review and may need to be modified further since there is also darwin to consider.

func sysProcAttr(cmd *exec.Cmd) {
cmd.SysProcAttr = &syscall.SysProcAttr{
	CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP,
}

}

Any whoo, I notice when you call a binary pushup.exe file that the scaffold files are not being handled correctly in the binary, it's like they are not there:

PS C:\stuff> .\pushup\pushup.exe new my_project

    //
 //  //      //////                        //
            //    //  //    //    //////  //////    //    //  //////
           //////    //    //  ////      //    //  //    //  //    //
          //        //    //      ////  //    //  //    //  //    //
         //          //////  //////    //    //    //////  //////
                                                          //
                                                         //

new command: copying scaffold file to project dir opening file from FS scaffold\layouts\default.up: open scaffold\layouts\default.up: file does not exist

Looking in to cause but I figured I should raise this as an issue.

@RightFootConsulting
Copy link
Author

RightFootConsulting commented Jan 3, 2024

This pull request fixes the issue.

#121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant