Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some edge cases not caught by audit_ssh_authorizedkeys #20

Open
s3lph opened this issue Jan 5, 2023 · 2 comments
Open

Some edge cases not caught by audit_ssh_authorizedkeys #20

s3lph opened this issue Jan 5, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@s3lph
Copy link
Collaborator

s3lph commented Jan 5, 2023

Some edge cases are not caught by the audit_ssh_authorizedkeys module. Namely those where SSH keys are loaded using token-expanded filenames other than %u, e.g. by matching for the remote hostname (%h).

audit_ssh_authorizedkeys should notice this and produce a warning, but this is not entirely trivial, as we'd need to parse the config file ourselves (sshd configtest only produces merged and expanded config as output, so we can't reliably check for placeholders there) in order to find any includes of other config files (at least the includes don't use token expansion).

@s3lph s3lph self-assigned this Jan 5, 2023
@s3lph
Copy link
Collaborator Author

s3lph commented Jan 5, 2023

Another case we should detect and emit a warning is the use of the AuthorizedKeysCommand option (e.g. when obtaining SSH keys via SSSD/LDAP).

@s3lph
Copy link
Collaborator Author

s3lph commented Jan 18, 2023

AuthorizedKeysCommand is covered by #29

@s3lph s3lph added the enhancement New feature or request label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant