You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was going through your source, and I couldn't understand what g stood for, maybe I could rename the function or add a comment?
(defng
[& content]
(if (and (=1 (count content))
(not (keyword? (first (first content)))))
;; content is a list of a list of elements
(into [:g {}] (first content))
;; content is a single element OR a list of elements
(into [:g {}] (filter (complement nil?) content))))
The text was updated successfully, but these errors were encountered:
This was an intentional choice. I want functions which emit SVG tags to share the name of said tag. So, 'group' tags are in SVG.
You are right to point out that it may be confusing. This is an issue I'll solve with better documentation. That is the next major thing I'm working on in the next few days, so I think that'll be sorted soon.
Adding a comment, I think, is fine for devs reading the source, but doesn't adequately address a library user who may face similar confusion that you pointed out here.
Basically, thanks for pointing this out, I will close the issue when I've pushed a documentation update :)
hey Adam, abhinav from twitter.
I was going through your source, and I couldn't understand what g stood for, maybe I could rename the function or add a comment?
The text was updated successfully, but these errors were encountered: