Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong license? Shouldn't this library be GPL v3? #100

Closed
walchko opened this issue Jan 18, 2021 · 9 comments
Closed

Wrong license? Shouldn't this library be GPL v3? #100

walchko opened this issue Jan 18, 2021 · 9 comments
Assignees

Comments

@walchko
Copy link

walchko commented Jan 18, 2021

Hello, I was poking around and noticed the license on the vector, quaternion, etc files you have in the utility directory has this:

    Inertial Measurement Unit Maths Library
    Copyright (C) 2013-2014  Samuel Cowen
        www.camelsoftware.com
    Bug fixes and cleanups by Gé Vissers ([email protected])
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.

This is GPL code ... how is this library then MIT? I would suggest ditching this code, I don't think it is really fully utilized any ways and you could just use a simple struct (or something) to hold the data ... JMHO

@ladyada
Copy link
Member

ladyada commented Jan 18, 2021

thanks, if you can submit a PR for the swapped-in version that is freely licensable that would be awesome!

@walchko
Copy link
Author

walchko commented Jan 18, 2021

ok

@walchko
Copy link
Author

walchko commented Jan 18, 2021

#101 ok ... how is this? I tried not to change too much, just made it simpler since you didn't use all of the capabilities.

@walchko
Copy link
Author

walchko commented Jan 18, 2021

oh, should I have bumped the version number in the library.properties file?

@supercamel
Copy link

Hello, I'm the original author of that code. It's been floating around the internet in various forms for years and I have no problem changing it to MIT or similar license.

@ladyada
Copy link
Member

ladyada commented Sep 12, 2021

@supercamel ok would you be ok publishing the new licensed code somewhere? we'll swap it in. thank you!!!

@supercamel
Copy link

Sure, here it is

https://github.com/supercamel/imumaths

@ladyada
Copy link
Member

ladyada commented Sep 23, 2021

@caternuson at your convenience!

@caternuson
Copy link
Contributor

Done with #111

Huge thanks to @supercamel for supporting this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants