From dad8c64c7bda2893ce606382e456efcbe1afda62 Mon Sep 17 00:00:00 2001 From: gabe Date: Mon, 28 Oct 2024 23:30:38 -0400 Subject: [PATCH 1/5] add buttons for combined-account transaction pages (#2333) --- .../components/mobile/accounts/Accounts.jsx | 37 +++++++++++++------ 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx b/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx index 6084b3713df..76c10473301 100644 --- a/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx +++ b/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx @@ -8,7 +8,7 @@ import { useAccounts } from '../../../hooks/useAccounts'; import { useFailedAccounts } from '../../../hooks/useFailedAccounts'; import { useNavigate } from '../../../hooks/useNavigate'; import { useSyncedPref } from '../../../hooks/useSyncedPref'; -import { SvgAdd } from '../../../icons/v1'; +import { SvgAdd, SvgCheveronRight } from '../../../icons/v1'; import { theme, styles } from '../../../style'; import { makeAmountFullStyle } from '../../budget/util'; import { Button } from '../../common/Button2'; @@ -20,36 +20,46 @@ import { CellValue, CellValueText } from '../../spreadsheet/CellValue'; import { MOBILE_NAV_HEIGHT } from '../MobileNavTabs'; import { PullToRefresh } from '../PullToRefresh'; -function AccountHeader({ name, amount, style = {} }) { +function AccountHeader({ id, name, amount, style = {} }) { + const navigate = useNavigate(); + return ( - navigate(`/accounts/${id}`)} style={{ flex: 1, flexDirection: 'row', marginTop: 10, - marginRight: 10, + padding: 0, color: theme.pageTextLight, width: '100%', ...style, }} > - + {name} + - {props => ( - - )} + {props => } - + ); } @@ -186,7 +196,11 @@ function AccountList({ {budgetedAccounts.length > 0 && ( - + )} {budgetedAccounts.map(acct => ( 0 && ( Date: Fri, 25 Oct 2024 00:09:52 -0400 Subject: [PATCH 2/5] add release note for #3734 --- upcoming-release-notes/3734.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 upcoming-release-notes/3734.md diff --git a/upcoming-release-notes/3734.md b/upcoming-release-notes/3734.md new file mode 100644 index 00000000000..9cebf0a7b87 --- /dev/null +++ b/upcoming-release-notes/3734.md @@ -0,0 +1,6 @@ +--- +category: Enhancements +authors: [GabeKlavans] +--- + +Add navigation to combined-accounts transactions lists from the accounts page on mobile. From 7a9bb80f942b27f546346598353297b501c6bb7b Mon Sep 17 00:00:00 2001 From: gabe Date: Mon, 28 Oct 2024 23:53:22 -0400 Subject: [PATCH 3/5] add accessibility label to mobile combined-account header button --- .../desktop-client/src/components/mobile/accounts/Accounts.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx b/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx index 76c10473301..750256cf443 100644 --- a/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx +++ b/packages/desktop-client/src/components/mobile/accounts/Accounts.jsx @@ -26,6 +26,7 @@ function AccountHeader({ id, name, amount, style = {} }) { return (