Ubuntu 20.04 GPU Image Rewrite, master branch (2024.05.19.) #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly big design change that I'm proposing here. I'd like to switch to having all of the "GPU images" be based on the "vanilla image", just putting the GPU SDKs on top of that base, vanilla image.
There are a number of reasons behind all of this.
traccc_sycl
.)traccc
.Note that I only went with a "single layer" of image inheritance in the end. So, the CUDA+oneAPI and ROCm+oneAPI images are built on top of the same "vanilla" Ubuntu 20.04 base image that the "non-hybrid" images are also built on top of. This is for 2 reasons:
Also note that I went with oneAPI 2024.1 as the oneAPI version in all the images. It is not actually functional with the current
traccc
main branch just yet. But with acts-project/traccc#591 and acts-project/detray#734 having gone in already, by the time that we get a new tag of this repository, we'll be able to use these images. 😉Finally: Note that I didn't add the Codeplay plugins to the "combined images". But this doesn't actually prevent us from testing the build of SYCL code with an NVIDIA or AMD backend. It just means that we can't (currently) runtime test the binaries using these images. 😦 I intend to figure out later on how to install these plugins, but for this first PR it didn't seem absolutely necessary. (Unfortunately the download of the pre-built Codeplay binaries cannot be automated at the moment.)
Also pinging @beomki-yeo and @stephenswat for info.