oneAPI / SYCL Image Updates, master branch (2024.05.30.) #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the SYCL build flags for AMD and NVIDIA backends.
The main motivation was to change the setup of the AMD backend. Since as it turns out, traccc cannot be compiled for the
gfx803
architecture (which is what my personal RX580 card has...) anymore. 🤔 One gets such a scary crash with it during linking:After playing around for a bit, I found that the
gfx1031
architecture (used by our developer machine's RX6700XT card...) still works,But as long as I was already doing this, I also simplified the images to only build SYCL code for AMD / NVIDIA backends respectably. Since building
traccc::sycl
for both Intel + AMD/NVIDIA backends takes a ridiculous amount of time. Not to mention that it's also pretty fragile.Pinging @andiwand for info. 😉