Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean event generator includes in Examples #3964

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Dec 7, 2024

No description provided.

@andiwand andiwand added this to the next milestone Dec 7, 2024
Copy link

coderabbitai bot commented Dec 7, 2024

Walkthrough

Changes made to several files focus on removing unused header files and refining the logic within the EventGenerator and related classes. The EventGenerator.cpp and ParametricParticleGenerator.cpp files have been decluttered by eliminating unnecessary includes, while the EventGenerator.hpp introduces a new struct, AlgorithmContext. The Pythia8ProcessGenerator.cpp enhances error handling in its methods. Overall, the modifications streamline the codebase while preserving core functionalities.

Changes

File Path Change Summary
Examples/Algorithms/Generators/ActsExamples/Generators/EventGenerator.cpp Removed unused headers; logic in EventGenerator class remains unchanged.
Examples/Algorithms/Generators/ActsExamples/Generators/EventGenerator.hpp Added new struct AlgorithmContext.
Examples/Algorithms/Generators/ActsExamples/Generators/ParametricParticleGenerator.cpp Removed unused include; refined constructor for member variable initialization.
Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.cpp Removed unused include; added error handling in flat() method.

Possibly related PRs

Suggested labels

Component - Examples, automerge, Track Finding

Suggested reviewers

  • AJPfleger

In the code, a cleanup we see,
Unused headers, now set free.
Logic intact, new struct in sight,
Streamlined flow, oh what a delight!
Yoda’s wisdom, guiding the way,
In code we trust, come what may! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5e8efd6 and 7285d0d.

📒 Files selected for processing (4)
  • Examples/Algorithms/Generators/ActsExamples/Generators/EventGenerator.cpp (0 hunks)
  • Examples/Algorithms/Generators/ActsExamples/Generators/EventGenerator.hpp (0 hunks)
  • Examples/Algorithms/Generators/ActsExamples/Generators/ParametricParticleGenerator.cpp (0 hunks)
  • Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.cpp (0 hunks)
💤 Files with no reviewable changes (4)
  • Examples/Algorithms/Generators/ActsExamples/Generators/EventGenerator.hpp
  • Examples/Algorithms/Generators/ActsExamples/Generators/EventGenerator.cpp
  • Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.cpp
  • Examples/Algorithms/Generators/ActsExamples/Generators/ParametricParticleGenerator.cpp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

📊: Physics performance monitoring for 269bed1

Full contents

physmon summary

Copy link

sonarcloud bot commented Dec 9, 2024

@kodiakhq kodiakhq bot merged commit 0a11443 into acts-project:main Dec 9, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Dec 9, 2024
@andiwand andiwand deleted the chore-clean-eventgen-includes branch December 9, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants