Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug?: ransackable_attributes Fails with Symbol Array #1538

Open
tatematsu-k opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1539
Open

Bug?: ransackable_attributes Fails with Symbol Array #1538

tatematsu-k opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1539

Comments

@tatematsu-k
Copy link

tatematsu-k commented Nov 21, 2024

When using the ransackable_attributes method in ActiveRecord, passing an array of symbols causes the search conditions for the corresponding attributes to be ignored. However, passing an array of strings works as expected.

Steps to Reproduce

1: Create a migration for a users table with a name column:

class CreateUsers < ActiveRecord::Migration[7.1]
  def change
    create_table :users do |t|
      t.string :name

      t.timestamps
    end
  end
end

2: Define the User model with ransackable_attributes returning a symbol array:

class User < ApplicationRecord
  def self.ransackable_attributes(auth_object = nil)
    [:name]
  end
end

3: Attempt to perform a Ransack query with a condition on the name attribute:

User.ransack(name_cont: "hoge").result.to_sql

Actual Behavior

The generated SQL query ignores the condition for name:

SELECT "users".* FROM "users"

I expected SELECT "users".* FROM "users" WHERE "users"."name" LIKE '%hoge%'

===

The code below returned the expected results:

class User < ApplicationRecord
  def self.ransackable_attributes(auth_object = nil)
    ["name"]
  end
end

===
Ruby version: 3.3.6
Rails version: 7.2.2
ransack version: 4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant