Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupdb: Allows to specify the db schema to backup. #44

Closed
wants to merge 1 commit into from
Closed

backupdb: Allows to specify the db schema to backup. #44

wants to merge 1 commit into from

Conversation

lmignon
Copy link
Member

@lmignon lmignon commented Mar 24, 2019

fixes #37

@sbidoul
Copy link
Member

sbidoul commented Mar 24, 2019

@lmignon rebasing should get you a green build (#46). Strangely enough, the backup test error we have seen do not appear anymore?

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #44 into master will decrease coverage by 1.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   92.91%   91.69%   -1.23%     
==========================================
  Files          13       13              
  Lines         706      710       +4     
  Branches      115      116       +1     
==========================================
- Hits          656      651       -5     
- Misses         36       41       +5     
- Partials       14       18       +4
Impacted Files Coverage Δ
click_odoo_contrib/backupdb.py 98.33% <100%> (-1.67%) ⬇️
click_odoo_contrib/initdb.py 94.2% <0%> (-2.9%) ⬇️
click_odoo_contrib/update.py 93.33% <0%> (-2.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960f575...7659387. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 24, 2019 •
edited
Loading

Codecov Report

Merging #44 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   92.91%   92.95%   +0.03%     
==========================================
  Files          13       13              
  Lines         706      710       +4     
  Branches      115      116       +1     
==========================================
+ Hits          656      660       +4     
  Misses         36       36              
  Partials       14       14
Impacted Files Coverage Δ
click_odoo_contrib/backupdb.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960f575...7659387. Read the comment docs.

@lmignon
Copy link
Member Author

lmignon commented Mar 24, 2019

@lmignon rebasing should get you a green build (#46). Strangely enough, the backup test error we have seen do not appear anymore?

Rebase done. Indeed, strange. Don't understand why the error has disappeared.

@sbidoul sbidoul added the WIP label Mar 27, 2019
@sbidoul
Copy link
Member

sbidoul commented Mar 27, 2019

Putting this in WIP for now since I'm not sure what we are fixing exactly

@lmignon
Copy link
Member Author

lmignon commented Mar 27, 2019

@sbidoul OK. Indeed, even if I had errors without these changes previously on ma machine, I'm no more have troubles without these.... Maybe a problem into pg_dump.

@lmignon
Copy link
Member Author

lmignon commented Oct 11, 2019

closing since this bug seems to no more occurs

@lmignon lmignon closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

click-odoo-backupdb: dump does not exlude non public data
2 participants
@lmignon @sbidoul