From 987de89ce4f60f9c2faeac695999bf207bd332ae Mon Sep 17 00:00:00 2001 From: Piotr Skrydalewicz Date: Thu, 19 Dec 2024 18:18:04 +0100 Subject: [PATCH 1/5] feat(executor): Add envsFrom to the executor --- charts/datahub-executor-worker/templates/workload.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/charts/datahub-executor-worker/templates/workload.yaml b/charts/datahub-executor-worker/templates/workload.yaml index 75864aa..304198c 100644 --- a/charts/datahub-executor-worker/templates/workload.yaml +++ b/charts/datahub-executor-worker/templates/workload.yaml @@ -142,9 +142,13 @@ spec: value: {{ .Values.global.datahub.executor.ingestions.signal_poll_interval | quote }} - name: DATAHUB_EXECUTOR_MONITORS_MAX_WORKERS value: {{ .Values.global.datahub.executor.monitors.max_workers | quote }} - {{- if .Values.extraEnvs }} + {{- if .Values.extraEnvs -}} {{ toYaml .Values.extraEnvs | nindent 12 }} {{- end }} + {{- if .Values.extraEnvsFrom }} + envFrom: + {{- toYaml .Values.extraEnvsFrom | nindent 12 }} + {{- end }} volumeMounts: {{- if .Values.extraCaCerts }} - name: ca-certs From 63f038a97aad6a74ae70734b6411d6f2e868bb37 Mon Sep 17 00:00:00 2001 From: Piotr Skrydalewicz Date: Thu, 19 Dec 2024 18:28:38 +0100 Subject: [PATCH 2/5] Incremented Chart version, provided appVersion as well --- charts/datahub-executor-worker/Chart.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/datahub-executor-worker/Chart.yaml b/charts/datahub-executor-worker/Chart.yaml index f8e5db7..7ef35fc 100644 --- a/charts/datahub-executor-worker/Chart.yaml +++ b/charts/datahub-executor-worker/Chart.yaml @@ -2,8 +2,8 @@ apiVersion: v2 name: datahub-executor-worker description: A Helm chart for datahub-executor-worker type: application -version: 0.0.11 -appVersion: 0.0.1 +version: 0.0.12 +appVersion: 3.7.3 maintainers: - name: DataHub email: datahub@acryl.io From 4e6c69dd53ae2408208b6d3bd3f2cb8fc842c30f Mon Sep 17 00:00:00 2001 From: Piotr Skrydalewicz Date: Thu, 19 Dec 2024 18:46:28 +0100 Subject: [PATCH 3/5] Bumping python dependency --- .github/workflows/lint-test.yaml | 2 +- charts/datahub-executor-worker/Chart.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index b7eddf9..9d9b2d8 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -30,7 +30,7 @@ jobs: - uses: actions/setup-python@v2 with: - python-version: 3.7 + python-version: 3.10 - name: Set up chart-testing uses: helm/chart-testing-action@v2.0.1 diff --git a/charts/datahub-executor-worker/Chart.yaml b/charts/datahub-executor-worker/Chart.yaml index 7ef35fc..158d3f3 100644 --- a/charts/datahub-executor-worker/Chart.yaml +++ b/charts/datahub-executor-worker/Chart.yaml @@ -3,7 +3,7 @@ name: datahub-executor-worker description: A Helm chart for datahub-executor-worker type: application version: 0.0.12 -appVersion: 3.7.3 +appVersion: 0.3.7.3 maintainers: - name: DataHub email: datahub@acryl.io From 154609b23099e7424ee5bd8c9910eecc4b52c7b5 Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Thu, 19 Dec 2024 12:13:03 -0600 Subject: [PATCH 4/5] Update lint-test.yaml --- .github/workflows/lint-test.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index 9d9b2d8..c2fe7c0 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -28,9 +28,10 @@ jobs: with: version: v3.4.0 - - uses: actions/setup-python@v2 + - uses: actions/setup-python@v5 with: - python-version: 3.10 + python-version: "3.10" + cache: "pip" - name: Set up chart-testing uses: helm/chart-testing-action@v2.0.1 From 28f648926970b533dbef9594d29e2a63d65ed806 Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Thu, 19 Dec 2024 12:47:49 -0600 Subject: [PATCH 5/5] Update lint-test.yaml --- .github/workflows/lint-test.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index c2fe7c0..7d381af 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -31,7 +31,6 @@ jobs: - uses: actions/setup-python@v5 with: python-version: "3.10" - cache: "pip" - name: Set up chart-testing uses: helm/chart-testing-action@v2.0.1