From eaedce8822bf4b523d728002596e735ee5bf4e24 Mon Sep 17 00:00:00 2001 From: Matt Rice Date: Thu, 19 Dec 2024 16:00:36 -0500 Subject: [PATCH 1/3] Add dohaki to codeowners (#1959) --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index ab1de9d02..2f253cd22 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -6,4 +6,4 @@ # These owners will be the default owners for everything in # the repo unless a later match takes precedence. -* @mrice32 @nicholaspai @pxrl @james-a-morris +* @mrice32 @nicholaspai @pxrl @james-a-morris @dohaki From 27778413a3bd16b8068ef7f6d29d0acb3d213237 Mon Sep 17 00:00:00 2001 From: withbest Date: Fri, 20 Dec 2024 19:43:28 +0800 Subject: [PATCH 2/3] chore: fix some typos (#1960) Signed-off-by: withbest --- src/common/Constants.ts | 2 +- src/utils/CCTPUtils.ts | 2 +- src/utils/ProviderUtils.ts | 2 +- tasks/integration-tests.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common/Constants.ts b/src/common/Constants.ts index fb554b217..a620ceec5 100644 --- a/src/common/Constants.ts +++ b/src/common/Constants.ts @@ -499,7 +499,7 @@ export const SCROLL_CUSTOM_GATEWAY: { [chainId: number]: { l1: string; l2: strin }, }; -// Expected worst-case time for message from L1 to propogate to L2 in seconds +// Expected worst-case time for message from L1 to propagate to L2 in seconds export const EXPECTED_L1_TO_L2_MESSAGE_TIME = { [CHAIN_IDs.ALEPH_ZERO]: 20 * 60, [CHAIN_IDs.ARBITRUM]: 20 * 60, diff --git a/src/utils/CCTPUtils.ts b/src/utils/CCTPUtils.ts index 38d1c5170..f34f419b8 100644 --- a/src/utils/CCTPUtils.ts +++ b/src/utils/CCTPUtils.ts @@ -97,7 +97,7 @@ export async function retrieveOutstandingCCTPBridgeUSDCTransfers( return undefined; } // Call into the destinationMessageTransmitter contract to determine if the message has been processed - // on the destionation chain. We want to make sure the message **hasn't** been processed. + // on the destination chain. We want to make sure the message **hasn't** been processed. const isMessageProcessed = await hasCCTPMessageBeenProcessed(sourceDomain, nonce, destinationMessageTransmitter); if (isMessageProcessed) { return undefined; diff --git a/src/utils/ProviderUtils.ts b/src/utils/ProviderUtils.ts index 9f6e8e24a..94d8caca3 100644 --- a/src/utils/ProviderUtils.ts +++ b/src/utils/ProviderUtils.ts @@ -127,7 +127,7 @@ export async function getProvider( const rpcRateLimited = ({ nodeMaxConcurrency, logger }) => async (attempt: number, url: string): Promise => { - // Implement a slightly aggressive expontential backoff to account for fierce paralellism. + // Implement a slightly aggressive expontential backoff to account for fierce parallelism. // @todo: Start w/ maxConcurrency low and increase until 429 responses start arriving. const baseDelay = 1000 * Math.pow(2, attempt); // ms; attempt = [0, 1, 2, ...] const delayMs = baseDelay + baseDelay * Math.random(); diff --git a/tasks/integration-tests.ts b/tasks/integration-tests.ts index d09cd1f01..d4410be65 100644 --- a/tasks/integration-tests.ts +++ b/tasks/integration-tests.ts @@ -37,7 +37,7 @@ task("integration-tests", "Run integration tests against key Dataworker function // Override environment variables that we want to control for, for example we want to prevent the runner of this // script from sending any on-chain transactions. - process.env.POLLING_DELAY = "0"; // Set to severless mode so that bot terminates after successful run. + process.env.POLLING_DELAY = "0"; // Set to serverless mode so that bot terminates after successful run. process.env.DISPUTER_ENABLED = "true"; process.env.PROPOSER_ENABLED = "true"; process.env.EXECUTOR_ENABLED = "true"; From e9ad355f90016218ec989c709ee7e62c94648a59 Mon Sep 17 00:00:00 2001 From: nicholaspai <9457025+nicholaspai@users.noreply.github.com> Date: Fri, 20 Dec 2024 13:48:42 -0500 Subject: [PATCH 3/3] improve: Remove unused gasMarkup parameter (#1958) --- src/clients/ProfitClient.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/clients/ProfitClient.ts b/src/clients/ProfitClient.ts index af085aad9..c3377acd4 100644 --- a/src/clients/ProfitClient.ts +++ b/src/clients/ProfitClient.ts @@ -660,8 +660,6 @@ export class ProfitClient { // Fallback to Coingecko's free API for now. // TODO: Add support for Coingecko Pro. const coingeckoProApiKey = undefined; - // TODO: Set this once we figure out gas markup on the API side. - const gasMarkup = 0; // Call the factory to create a new QueryBase instance. return relayFeeCalculator.QueryBase__factory.create( chainId, @@ -670,8 +668,7 @@ export class ProfitClient { undefined, // spokePoolAddress undefined, // simulatedRelayerAddress coingeckoProApiKey, - this.logger, - gasMarkup + this.logger ); } }