Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampled_data/**/top_pagview.png should be top_pageview.png #1

Open
acmiyaguchi opened this issue Oct 20, 2019 · 0 comments
Open

sampled_data/**/top_pagview.png should be top_pageview.png #1

acmiyaguchi opened this issue Oct 20, 2019 · 0 comments

Comments

@acmiyaguchi
Copy link
Owner

See https://github.com/acmiyaguchi/cs229-f19-wiki-forecast/blob/8f1765ad8c29688a0ea2b1c9ddc493b182804143/sample_data/trial_5/top_pagview.png

This needs to be fixed within summarize-pageview. Test the fix by running:

for i in {0..6}; do
    # rerun a specific trial
    artifact_path="sample_data/trial_$i"
    artifact="--artifact-path $artifact_path"
    seed=$(cat $artifact_path/seed.txt | cut -d, -f1)
    hops=$(cat $artifact_path/seed.txt | cut -d, -f3)
    scripts/run-command subgraph sample --article-seed $seed --k-hops $hops $artifact
    scripts/run-command subgraph summarize-graph $artifact
    scripts/run-command subgraph pageview $artifact
    scripts/run-command subgraph summarize-pageview $artifact
done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant