Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniyal/title file #25

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Daniyal/title file #25

wants to merge 11 commits into from
+27 −6

Conversation

daniyalbhat34
Copy link
Collaborator

Added the title component.

@daniyalbhat34 daniyalbhat34 self-assigned this Jan 21, 2025
@daniyalbhat34 daniyalbhat34 linked an issue Jan 21, 2025 that may be closed by this pull request
Create Title Component #4
Open
@arieen17
Copy link
Contributor

Hihi! you did not fulfill all the checks, from what I can see you did not provide a "text" for when you called the "Header" component!

@daniyalbhat34 daniyalbhat34 requested review from arieen17 and removed request for fardinzam January 21, 2025 22:14
arieen17
arieen17 reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@arieen17 arieen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! Could you add an image of local website, as to what your changes look like, just to double check visually?

@daniyalbhat34
Copy link
Collaborator Author

Screenshot (532)
It's not complete yet.

arieen17
arieen17 reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@arieen17 arieen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We will add the font in a bit, so don't worry about that. Can you offset the SVG's similar to how it looks in the SS/Figma?

@daniyalbhat34
Copy link
Collaborator Author

I will finish it soon.

@daniyalbhat34
Copy link
Collaborator Author

Screenshot (534)
This is what I have been able to do till now.

arieen17
arieen17 reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@arieen17 arieen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello last few comments, dont worry about the offsetting the img we can come back to that later on. For now, delete the border-indigo and the border-t (those were an accidentally highlight on the figma).And for the width of the images we could just use w-1/2 (it should be bigger). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arieen17 arieen17 arieen17 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@daniyalbhat34 daniyalbhat34

Labels
address comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Title Component
2 participants
@daniyalbhat34 @arieen17