sriov: added unit test for PullOperatorConfig func (openshift-kni#319)

Co-authored-by: nkononov <[email protected]>
achuzhoy · Apr 4, 2024 · c548f69 · c548f69
1 parent 59978c1
commit c548f69
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/pkg/sriov/operatorconfig.go b/pkg/sriov/operatorconfig.go
@@ -82,6 +82,12 @@ func (builder *OperatorConfigBuilder) Create() (*OperatorConfigBuilder, error) {
 func PullOperatorConfig(apiClient *clients.Settings, nsname string) (*OperatorConfigBuilder, error) {
 	glog.V(100).Infof("Pulling existing default SriovOperatorConfig: %s", sriovOperatorConfigName)
 
+	if apiClient == nil {
+		glog.V(100).Infof("The apiClient is empty")
+
+		return nil, fmt.Errorf("SriovOperatorConfig 'apiClient' cannot be empty")
+	}
+
 	builder := OperatorConfigBuilder{
 		apiClient: apiClient.ClientSrIov,
 		Definition: &srIovV1.SriovOperatorConfig{

diff --git a/pkg/sriov/operatorconfig_test.go b/pkg/sriov/operatorconfig_test.go
@@ -39,6 +39,13 @@ func TestPullOperatorConfig(t *testing.T) {
 			addToRuntimeObjects:     true,
 			client:                  true,
 		},
+		{
+			operatorConfigNamespace: "test-namespace",
+			expectedError:           true,
+			expectedErrorText:       "SriovOperatorConfig 'apiClient' cannot be empty",
+			addToRuntimeObjects:     true,
+			client:                  false,
+		},
 		{
 			operatorConfigNamespace: "test-namespace",
 			expectedError:           true,