Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling for len attribute in vk.xml #1

Open
achirkin opened this issue Feb 19, 2018 · 0 comments
Open

Better handling for len attribute in vk.xml #1

achirkin opened this issue Feb 19, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@achirkin
Copy link
Owner

vulkan/genvulkan/src/VkXml/Sections/Types.hs

Lines 210 to 214 in 84a01f4

parseAttrVkMemberLen :: ReaderT ParseLoc AttrParser (Maybe Text)
parseAttrVkMemberLen = lift $ do
maltlen <- attr "altlen"
mlen <- attr "len"
pure $ maltlen <|> mlen

Make len and altlen parsing more correct and robust w.r.t. spec 10.2.2 "attributes of member tags".
@achirkin achirkin added enhancement New feature or request help wanted Extra attention is needed labels Feb 19, 2018
@achirkin achirkin removed the help wanted Extra attention is needed label May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achirkin