From 25379e6fa1e41e72d41563dfe588220508fae60d Mon Sep 17 00:00:00 2001 From: Adam Getchell Date: Sat, 27 Jan 2024 10:57:22 -0800 Subject: [PATCH] Boost 1.84 Small fixes in bistellar-flip.cpp. This commit is to document a compile-time bug with vcpkg's CGAL port with the qt feature enabled. --- README.md | 6 ++++-- src/bistellar-flip.cpp | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index df0a91920..a11bb26b6 100644 --- a/README.md +++ b/README.md @@ -405,9 +405,11 @@ Optional: ## Issues -[vcpkg]'s version of [date] has an unfixed bug [#23637] which produces `use-of-uninitialized-value` in [MemorySanitizer]. +- macOS currently doesn't build with Qt, see https://github.com/microsoft/vcpkg/issues/36409 -[docopt] also has a `use-of-uninitialized-value` bug ([#149]). +- [vcpkg]'s version of [date] has an unfixed bug [#23637] which produces `use-of-uninitialized-value` in [MemorySanitizer]. + +- [docopt] also has a `use-of-uninitialized-value` bug ([#149]). [#23637]: https://github.com/microsoft/vcpkg/issues/23637 [#149]: https://github.com/docopt/docopt.cpp/issues/149 diff --git a/src/bistellar-flip.cpp b/src/bistellar-flip.cpp index 73a33ffd2..064edcfa5 100644 --- a/src/bistellar-flip.cpp +++ b/src/bistellar-flip.cpp @@ -64,9 +64,9 @@ try #ifdef NDEBUG fmt::print("Before bistellar flip.\n"); - auto vertices = bistellar_triangulation_vertices(); - ergodic_moves::Delaunay dt{vertices.begin(), vertices.end()}; - manifolds::Manifold_3 manifold{ + auto vertices = bistellar_triangulation_vertices(); + ergodic_moves::Delaunay const dt{vertices.begin(), vertices.end()}; + manifolds::Manifold_3 const manifold{ foliated_triangulations::FoliatedTriangulation_3{dt, 0, 1} }; CGAL::draw(manifold.get_delaunay());