Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add temporary achievement progress #53

Open
acenturyandabit opened this issue Jul 1, 2021 · 4 comments
Open

Enhancement: Add temporary achievement progress #53

acenturyandabit opened this issue Jul 1, 2021 · 4 comments
Assignees

Comments

@acenturyandabit
Copy link
Owner

Currently there are two ways of validating achievements: Either the achievement's progress is saved, or the achievement's progress is transient. For transient achievements, the progress bar doesn't show up.

Edit the transient acheivements checking function and associated data so that a progress bar for the acheivements shows up.

@acenturyandabit acenturyandabit changed the title Add temporary achievement progress Enhancement: Add temporary achievement progress Jul 2, 2021
@sudesh7447
Copy link

Hey I'm a beginner in open source but i think I can add this Enhancement. Can you assign this to me?

@PushpenderSaini0
Copy link
Collaborator

Yes @sudesh7447 , i am assigning you this, you can later submit a pull request mentioning this issue, i will review it and merge .
You can @ me whenever you need help !

@sudesh7447
Copy link

Thanks sir! can you explain the task a little bit more specifically?

@acenturyandabit
Copy link
Owner Author

acenturyandabit commented Sep 26, 2021

Sure!
-------------------- Steps to reproduce -------------------

  1. Open https://acenturyandabit.github.io/fortknight in an incognito window.
  2. Click the "Scores and Achievements" tab. The first achievement should be "Lazy".
  3. Start a game. Click the knight to waste a move. You should see the "Lazy" bar fill up a bit.
  4. Do another lazy move (Click the knight to waste a move). You should see the "Lazy" bar fill up a bit more.
  5. Now, don't do any more lazy moves - keep moving and lose.

Intended behaviour: The "Lazy" bar keeps showing the 2 lazy moves that you did, in a different colour (maybe red), after the game. This transient progress does not reset between games, even though the actual progress resets between games.

Actual behavior: The "Lazy" bar clears, and you lose all your progress.
-------------------- Coding Hints --------------------------
Check out the file js/achievements_highscores.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants