Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections without Concepts are not exported #46

Open
KlausIllmayer opened this issue Aug 4, 2022 · 3 comments
Open

Collections without Concepts are not exported #46

KlausIllmayer opened this issue Aug 4, 2022 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@KlausIllmayer
Copy link

Currently if I export a ConceptScheme that contains Collections without Concepts, such Collections will not show up in the dump (one example is our VICAV. It could be that skosify kicks them out. Just to be sure, is this a behavior built into vocabseditor or is it indeed skosify that does this clean-up?

tbd: If vocabseditor is ignoring such Collections, then I tend to put them into the export. If skosify is the reason, then we accept it.

@KlausIllmayer KlausIllmayer added the question Further information is requested label Aug 4, 2022
@csae8092
Copy link
Member

csae8092 commented Aug 5, 2022

The main entity for the export is the SkocConcept (process all concepts related to the given schema); thus collections without any related concepts are ignored (see e.g. https://github.com/acdh-oeaw/vocabseditor/blob/master/vocabs/rdf_utils.py#L98)
we can of course change this but whats the use of collection with no concepts?
@KlausIllmayer please decide if I should include those collections

@KlausIllmayer
Copy link
Author

Indeed, vocabularies in production should not have Collections without Concepts. But in case of vocabularies in development it may make sense. I can imagine that you point curators/reviewers to a bundle of Collections for comments and to add new Concepts based on an initial set of Collections. Usually this should happen in the vocabseditor but it could be, that external users don't use vocabseditor and instead only have access to the Skosmos view (where I guess, that such Collections show up). I don't think that it is a frequent workflow, but who knows. In general, I would pass over such a decision to Skosify. So if it is only a minor change on your side, please include those collections -(otherwise lets leave it as it is now and have it documented).

@csae8092
Copy link
Member

sorry, I forgot this issue a bit. I'd say we keep it as it because changing it means some more coding and I think we should not encourage users to do some workarounds outside Vocabseditor
@KlausIllmayer any ideas where this should be documented?

@csae8092 csae8092 assigned KlausIllmayer and unassigned csae8092 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants