Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to CakePHP 5.0 #85

Open
2 tasks
patrickakk opened this issue Sep 15, 2023 · 6 comments
Open
2 tasks

Migrate to CakePHP 5.0 #85

patrickakk opened this issue Sep 15, 2023 · 6 comments
Labels
admin Admin - Part of application frontend Front End - Part of application maintenance No bug or feature request, but needed to stay up to date with technologies - Kind of issue
Milestone

Comments

@patrickakk
Copy link
Contributor

A new version of the framework is released.

  • Migrate to version 5.0 incl fixing deprecation warnings or refactoring
  • Includes also migration to PHPUnit 10.x
@patrickakk patrickakk added frontend Front End - Part of application admin Admin - Part of application todo Ready to start development - Status of issue maintenance No bug or feature request, but needed to stay up to date with technologies - Kind of issue labels Sep 15, 2023
@patrickakk patrickakk added this to the 2024 milestone Dec 5, 2023
@patrickakk patrickakk modified the milestones: 2024, April 2024 Jan 31, 2024
@patrickakk patrickakk modified the milestones: April 2024, June 2024 Mar 27, 2024
@patrickakk patrickakk self-assigned this May 30, 2024
@patrickakk patrickakk modified the milestones: June 2024, July 2024 Jun 12, 2024
@patrickakk patrickakk modified the milestones: July 2024, August 2024 Aug 27, 2024
@patrickakk patrickakk added indev Currently in development – Status of issue and removed todo Ready to start development - Status of issue labels Aug 27, 2024
@patrickakk
Copy link
Contributor Author

Explanation:
This task contains fixing deprecations from PHP 8.2 and 8.3, the migration to a new major release of the framework (CakePHP 5.0) and migration to Phpunit 10.x

Al tough the amount of characters that are describing the task are small, this is an imported and complex task. Finishing it will be an important step forward in keeping up-to-date with current technology and also requires a bigger amount of time.

The new framework version contains a lot of breaking changes and as well in this migration is poor documented, which also makes it more complex.

@patrickakk patrickakk modified the milestones: August 2024, September 2024 Sep 3, 2024
@patrickakk patrickakk modified the milestones: 2024-09, 2024-10 Oct 2, 2024
@patrickakk patrickakk removed the indev Currently in development – Status of issue label Oct 30, 2024
@patrickakk
Copy link
Contributor Author

patrickakk commented Oct 30, 2024

Status update:
Migrated to CakePHP 4.5.7 and PHP 8.3

The application has been migrated to the latest version of the CakePHP 4.x branch, which is currently CakePHP 4.5.7

All deprecation warnings from both the Framework and PHP 8.2 and PHP 8.3 have been solved. As a part of this, the pagination in the login area was also restructured.

Migrating to the 5.x branch seems a complex task and might require a lot of time and unfortunaly the documentation is poor.

The changes are implemented in version 2024-10

@patrickakk patrickakk assigned PixlTracer and IvdL22 and unassigned patrickakk Oct 30, 2024
@patrickakk patrickakk added the inreview Request from dev to test and give feedback on the implementation of the issue - Status of issue label Oct 30, 2024
@patrickakk
Copy link
Contributor Author

@PixlTracer @IvdL22

The changes made (as described above) have impact at almost all the pages in the login area. Altough the code was updated, they should still work the same as before.

You can check everything out in the test instance if you want.

Do you want to review this or can we release it now?

In this case, no need to change the label to Done. Please remove the InReview label if you've replied here.

@PixlTracer PixlTracer assigned vronk and unassigned IvdL22 Oct 30, 2024
@PixlTracer PixlTracer removed their assignment Oct 30, 2024
@PixlTracer
Copy link

PixlTracer commented Oct 30, 2024

Hi Patrick,
I checked in test instance, everything looks good to me. In my opinion, you can proceed.
Just to be sure: kindly asking @vronk to look into it and give feedback too, thanks!

@patrickakk patrickakk removed the inreview Request from dev to test and give feedback on the implementation of the issue - Status of issue label Oct 30, 2024
@vronk
Copy link

vronk commented Nov 6, 2024

This looks fine. please proceed.

@patrickakk
Copy link
Contributor Author

Final note:
Migrated to CakePHP 4.5.7 and PHP 8.3

The changes are implemented in version 2024-10

As discussed in the meeting today, the upgrade to CakePHP 5.x will be postponed.

@patrickakk patrickakk modified the milestones: 2024-10, Someday Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Admin - Part of application frontend Front End - Part of application maintenance No bug or feature request, but needed to stay up to date with technologies - Kind of issue
Projects
None yet
Development

No branches or pull requests

4 participants