Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the default behaviour of the merge_with function for boolean fields #818

Closed
sennierer opened this issue May 8, 2024 · 2 comments · Fixed by #1195 or #1188
Closed

change the default behaviour of the merge_with function for boolean fields #818

sennierer opened this issue May 8, 2024 · 2 comments · Fixed by #1195 or #1188
Assignees

Comments

@sennierer
Copy link
Collaborator

currently booleanfields are connected via and when merged:

def merge_booleanfield(self, other, field):
setattr(
self, field.name, getattr(self, field.name) and getattr(other, field.name)
)

For boolean fields we want to keep the value in the source object

@b1rger
Copy link
Contributor

b1rger commented Aug 28, 2024

Is there anything we can do to move this along? Any assistance needed?

@gythaogg
Copy link
Contributor

My bad - shouldn't have ignored it. Just created a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants