-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird action elements placement in edit views #683
Comments
Ah, hmm, is it possible that my templates contain a mix of things while I'm not yet done implementing everything necessary for the switch to generic app? I just noticed that I'm also seeing the buttons in (generic) detail view, including the "view" button (!), which links to the old "detail" view. 🤔 (... unedited a previous edit after confirming I'm indeed seeing this in both views) |
I'm not really sure if I'm missing something, but the edit and updated views were redesigned during the switch to the generic app (well, actually, replaced, not redesigned). I'm not seeing anything wrong in the screenshot, but maybe I'm missing what exactly you are referring to |
It's the placement I'm primarily having an issue with. They are not visually grouped with the entity type + name. They sit on their own line, very far apart, a couple on the far left, the others hidden in a dropdown on the far right in a non-obvious way. (I only discovered them when I couldn't "see" them but knew they had to be there.) The grouping of icon + icon label looks off as well. And is inconsistent with how the buttons look in e.g. the table view. Don't get me wrong, the previous placement wasn't great either, nor were those separators. I started working on improving the old version at some point, maybe I still have the WIP branch around. It was mostly focussed on placement, probably about |
Yes. Should they?
Yes, those are two different menus. Primary and secondary actions, so to say. The primary menu uses bootstraps card navigation and list two views that use a similar layout , the secondary uses a navbar menu and lists actions that move the interaction to different pages and it provides a way to add additional actions. It is similar to the comment box I'm using to write this comment - "Write" and "Preview" at the left, a lot of other actions at the right. |
given that @koeaw doesnt have time to refactor that currently, we close this for now |
My
update
views all look like this at the top:... using generic app (URL is
/apis_ontology.work/update/X
).Is this intentional? A bug on my end? Potentially already fixed in a newer version? It's not super high priority and I could look into fixing this.
I generally wanted to suggest to turn the action buttons into actual buttons, which is why I already looked at the CSS for a bit a while ago. (Not for this template, but for list view; stopped short at this one.)
The text was updated successfully, but these errors were encountered: