Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include map visualization javascript #639

Closed
b1rger opened this issue Feb 14, 2024 · 0 comments · Fixed by #1192
Closed

Include map visualization javascript #639

b1rger opened this issue Feb 14, 2024 · 0 comments · Fixed by #1192

Comments

@b1rger
Copy link
Contributor

b1rger commented Feb 14, 2024

as implemented in acdh-oeaw/apis-instance-oebl-pfp@bbeefbb
koeaw added a commit that referenced this issue May 15, 2024
@koeaw
fix(apis_entities): fix faulty map JS
2b223fb 
Fix references to longitude, latitude values,
incorrect check for existing map.

Closes: #639
koeaw added a commit that referenced this issue May 15, 2024
@koeaw
fix(apis_entities): fix faulty map JS
a642379 
Fix references to longitude, latitude values,
incorrect check for existing map.

Closes: #639
@koeaw koeaw linked a pull request May 15, 2024 that will close this issue
Add ÖBL JS for map, fix problems with code #842
Closed
koeaw added a commit that referenced this issue May 15, 2024
@koeaw
fix(apis_entities): fix, update map JS
4a86a69 
Fix references to longitude, latitude values,
incorrect check for existing map; update variable
names, keywords following JavaScript best practices,
reorder statements for readabilty.

Closes: #639
koeaw pushed a commit that referenced this issue May 15, 2024
@b1rger @koeaw
feat(apis_entities): add JS and CSS for map
f6e84ac 
Add JavaScript and styling for map preview
of where places with longitude and latitude
datapoints are located.

Co-authored-by: KK <[email protected]>

Closes: #639
@koeaw koeaw linked a pull request Sep 19, 2024 that will close this issue
birger/639 popover map #1192
Merged
@koeaw koeaw removed their assignment Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@b1rger @koeaw