You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fact the former looks like it mirrors the duplicate method's implementation but not its name pattern throws an additional wrench into trying to infer what's what a glance.
Not sure if the word is meant to differentiate between different types of actions/views, but what I said above about it adding an element of confusion remains unchanged.
I think it would be helpful to add docstrings, if brief ones, to the merge methods in
AbstractEntity
.Specifically:
apis-core-rdf/apis_core/apis_entities/models.py
Line 87 in 1323d33
and:
apis-core-rdf/apis_core/apis_entities/models.py
Line 100 in 1323d33
The fact the former looks like it mirrors the duplicate method's implementation but not its name pattern throws an additional wrench into trying to infer what's what a glance.
apis-core-rdf/apis_core/apis_entities/models.py
Line 80 in 1323d33
The text was updated successfully, but these errors were encountered: