Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Grammar to Slate DOM with Wrapped Variables #151

Closed
jolanglinais opened this issue Dec 20, 2019 · 8 comments
Closed

Template Grammar to Slate DOM with Wrapped Variables #151

jolanglinais opened this issue Dec 20, 2019 · 8 comments

Comments

@jolanglinais
Copy link
Member

Is your feature request related to a problem? Please describe.
Need a way to go from a template grammar or sample to a Slate DOM with wrapVariables: true

Describe the solution you'd like
This will allow for rendering a formatted clause template without necessarily having the clauseTemplate

@jeromesimeon
Copy link
Member

jeromesimeon commented Jul 1, 2020

A good chunk of work for this has been done for this issue in the development branch. The approach is as follows:

  • define a DOM for the grammar (it is called templatemark)
  • create a parser for the grammar and transform to template mark
  • add a translation from templatemark to slate DOM (TODO)

@dselman
Copy link
Contributor

dselman commented Sep 21, 2020

@jeromesimeon can this be closed?

@jeromesimeon
Copy link
Member

I always interpreted this issue as encompassing grammar -> Slate transform as well. Which is technically still open. We could close this issue which isn't entirely clear and open a new one. @irmerk ?

@jolanglinais
Copy link
Member Author

Unsure, it sounds like it though? I'm not clear on if going from a template grammar or sample to a Slate DOM with wrapVariables: true is possible now.

@jeromesimeon
Copy link
Member

jeromesimeon commented Sep 21, 2020

wrapVariables: true does not exist anymore. But:

  • going from sample to Slate DOM does exist (that's what the ContractEditor uses).
  • going from grammar to Slate DOM does not exist (but would be needed if we want to do "design mode").

@jolanglinais
Copy link
Member Author

Happy to close this, but am not sure I understand the requirement enough to make a refined/updated issue. @jeromesimeon would you mind?

@jeromesimeon
Copy link
Member

Happy to close this, but am not sure I understand the requirement enough to make a refined/updated issue. @jeromesimeon would you mind?

hm. It would be useful to have at least a discussion about "design mode". Will we do it or not and if yes in which form.

@jeromesimeon
Copy link
Member

Closing this, replaced by newer #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants