Double Asterisk in File Search

[JamesHabben]

There are quite a few modules that have double asterisk marks at the start of their search pattern. I haven't done any speed tests to see if this impacts anything, but I used the fnmatch module to manually translate the given pattern with the double and removing one of them. The result is the same regex pattern that gets returned, and this is the function we use to translate the file search pattern to a regex for the seeker process. Documenting this here so others can see, and it seems that we can remove the double asterisk ** from modules that have it as we update them for other reasons.

Test code:

>>> import fnmatch
>>>
>>> fnmatch.translate('*asdf*')
'(?s:(?>.*?asdf).*)\\Z'
>>> fnmatch.translate('**asdf*')
'(?s:(?>.*?asdf).*)\\Z'
>>> 
>>> fnmatch.translate('**/Documents/AllTrails.sqlite*')
'(?s:(?>.*?/Documents/AllTrails\\.sqlite).*)\\Z'
>>> fnmatch.translate('*/Documents/AllTrails.sqlite*')
'(?s:(?>.*?/Documents/AllTrails\\.sqlite).*)\\Z'

Example module pattern: