HID_: Make methods overridden from base-class explicit #21
Conversation
Fixes abratchik#20. Done to make it clear that these virtual methods are defined in the PluggableUSBModule base-class and might be called from external code not seen in this repo.
|
@abratchik I am interested in the "HID power device" protocol and was therefore happy when stumbling across your project. I would ideally like to contribute back with pull-requests to improve it further. However, I don't want to force myself or to "drown" you in pull requests if you're not interested. Therefore, please let me know it you're interested in contributions, or else I'll instead fork your project and create my own version. Regardless, thanks a lot for sharing this project with others. |
|
Hi Fredrik, I'd be happy to accept your PRs, However, some changes I spotted are minor and some are changing the signatures of methods. I do not have the auto tests to validate your fixes and do not have time right now, unfortunately, for testing manually. I will review later this week and let you know my feedback on your submissions. Regards, Alex 12.09.2024, 14:40, "Fredrik Orderud" ***@***.***>***@***.*** I am interested in the "HID power device" protocol and was therefore happy when stumbling across your project. I would ideally like to contribute back with pull-requests to improve it further. However, I don't want to force myself or to "drown" you in pull requests if you're not interested. Therefore, please let me know it you're interested in contributions, or else I'll instead fork your project and create my own version.Regardless, thanks a lot for sharing this project with others.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> -- Regards, Alex Bratchik
|
|
Thanks a lot for your positive attitude @abratchik . I fully understand that it might take some time for you to review & test my pull requests. I've already tested my pull requests locally on an Arduino micro against Windows, but also have Mac & Linux machines available for testing. Don't hesitate to let me know if you want modifications and/or additional testing done from my end, and I'll do my best to accommodate it. |
|
I've submitted the same change proposal to ArduinoCore-avr in arduino/ArduinoCore-avr#569 |
Fixes #20. Done to make it clear that these virtual methods are defined in the
PluggableUSBModulebase-class and might be called from external code not seen in this repo.