Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ipaddress package. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardash1981
Copy link

A trivial change, but makes it usable on Gentoo / AMD64 / Python 3.7:

The ipaddress module is part of the python standard library from python 3.3 onwards, i.e. every maintained version of python. I found that having the dependency on ipaddress in setup.py broke nxBender on Python 3.7 (would not start with an error about not being able to find the package), so remove the dependency.

Error before this change:

$ nxBender
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.7/nxBender", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3251, in <module>
    @_call_aside
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3235, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3264, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'ipaddress' distribution was not found and is required by nxBender

The ipaddress module is part of the python standard library from python
3.3 onwards, i.e. every maintained version of python. I found that
having this in setup.py broke nxBender on Python 3.7 (would not start),
so remove the dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant