Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate integration tests crash #121

Closed
lawrence-forooghian opened this issue Nov 19, 2024 · 1 comment · Fixed by #146
Closed

Investigate integration tests crash #121

lawrence-forooghian opened this issue Nov 19, 2024 · 1 comment · Fixed by #146
Assignees
@lawrence-forooghian
Labels
bug Something isn’t working. It’s clear that this does need to be fixed. room-lifecycle Related to room lifecycle (temporary label).

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Nov 19, 2024 •
edited by sync-by-unito bot
Loading

Once in a while, the integration tests are crashing with Fatal error: State change event with resumed == false should have a reason, e.g. here. Can reproduce locally, and saw it happen in the example app once too. Need to understand if this will be fixed by #102, or if there's something else we need to do (i.e. is the spec’s assumption wrong?)

┆Issue is synchronized with this Jira Bug by Unito
@lawrence-forooghian lawrence-forooghian added bug Something isn’t working. It’s clear that this does need to be fixed. room-lifecycle Related to room lifecycle (temporary label). labels Nov 19, 2024
@lawrence-forooghian lawrence-forooghian self-assigned this Nov 19, 2024
@lawrence-forooghian
Copy link
Collaborator Author

Looks like the issue is still there after fixing #102.

lawrence-forooghian added a commit that referenced this issue Nov 19, 2024
@lawrence-forooghian
Add logging to help us understand #121
2a35df8
lawrence-forooghian added a commit that referenced this issue Nov 20, 2024
@lawrence-forooghian
Add logging to help us understand #121
9170e20
lawrence-forooghian added a commit that referenced this issue Nov 20, 2024
@lawrence-forooghian
Add logging to help us understand #121
d604203
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
@lawrence-forooghian
Add logging to help us understand #121
7afff22
lawrence-forooghian added a commit that referenced this issue Nov 25, 2024
@lawrence-forooghian
Add logging to help us understand #121
912a366
lawrence-forooghian added a commit that referenced this issue Nov 25, 2024
@lawrence-forooghian
Change criteria for deciding if discontinuity
8b352f2 
This fixes an intermittent crash ("Non-initial ATTACHED state change
with resumed == false should have a reason") in the integration tests
which happened because the manager sometimes processed the initial
ATTACHED contributor state change after the `attach()` call completed.
I’ve followed my first suggestion in [1] for how to address this.

Resolves #121

[1] ably/specification#239
lawrence-forooghian added a commit that referenced this issue Nov 25, 2024
@lawrence-forooghian
Change criteria for deciding if discontinuity
8b5aa47 
This fixes an intermittent crash ("Non-initial ATTACHED state change
with resumed == false should have a reason") in the integration tests
which happened because the manager sometimes processed the initial
ATTACHED contributor state change after the `attach()` call completed.
I’ve followed my first suggestion in [1] for how to address this.

Resolves #121.

[1] ably/specification#239
This was referenced Nov 25, 2024
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
bug Something isn’t working. It’s clear that this does need to be fixed. room-lifecycle Related to room lifecycle (temporary label).
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO-5123] Fix crash when running integration tests ably/ably-chat-swift
1 participant
@lawrence-forooghian