Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adaptive launcher icon #23

Open
abhijitparida opened this issue Oct 23, 2018 · 10 comments
Open

Add adaptive launcher icon #23

abhijitparida opened this issue Oct 23, 2018 · 10 comments
Milestone

Comments

@abhijitparida
Copy link
Owner

Source material:

  1. https://github.com/abhijitparida/bunk/blob/master/promo/logo.svg
  2. https://github.com/abhijitparida/bunk/blob/master/promo/playstore%20logo.png
@jashasweejena
Copy link
Contributor

I would like to work on this :)

@abhijitparida
Copy link
Owner Author

Sure, go ahead! But please keep the existing launcher icons as they are.

@jashasweejena
Copy link
Contributor

Sure, go ahead! But please keep the existing launcher icons as they are.

okay!

@jashasweejena
Copy link
Contributor

Actually was facing a couple of issues, probably because I recently updated to the latest Android Studio 3.2.
Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.3.1). this is one of 'em.
Fixed it by keeping google() above jcenter() on lines 6 in project level build.gradle. Should I make a separate PR for those? Another change I made was updated distributionUrl in gradle.properities to point to gradle version 4.10.2. Also there's a warning saying
The specified Android SDK Build Tools version (27.0.3) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.2.1. Android SDK Build Tools 28.0.3 will be used.
What do I do about 'em? Thanks for your time 😃

@abhijitparida
Copy link
Owner Author

Make a separate PR.

@jashasweejena
Copy link
Contributor

Make a separate PR.

Will one PR do? Or do I need to make more than one?

@abhijitparida
Copy link
Owner Author

Just one will do. Something like "Update build config for Android Studio 3.2".

@abhijitparida
Copy link
Owner Author

You might also have to modify .travis.yml if you are going to change the SDK Build Tools version.

@jashasweejena
Copy link
Contributor

Just one will do. Something like "Update build config for Android Studio 3.2".

Just did one! Please check.

@jashasweejena
Copy link
Contributor

You might also have to modify .travis.yml if you are going to change the SDK Build Tools version.

Oh. Android Studio didn't throw a warning or something tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants