Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Missing ShortId in the Database #109

Closed
Abh-I-seK opened this issue May 22, 2024 · 3 comments
Closed

Resolving Missing ShortId in the Database #109

Abh-I-seK opened this issue May 22, 2024 · 3 comments
Assignees

Comments

@Abh-I-seK
Copy link
Contributor

Describe the bug
After shortening a URL, we get an URL in form of https://urlsrt.vercel.app/data.
Now if we pass a arbitrary value in place of data then it shows the following.
In the example below, I used the URL : https://urlsrt.vercel.app/111222

image

So, I think if in getSpecificUrl() (in server/controller/urls.js)
once we find the data based on shortId then check if its null. If null, then we will redirect the user to an 404 page which will say that
"This link does not exist".

And will also add link to navbar, which will redirect to homepage.

Could you please assign this issue to me under GSSOC 24.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://urlsrt.vercel.app/111222

Expected behavior
The above screenshot.

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Arc
  • Version: 1.2.1 (29300)
Copy link

Congratulations, @Abh-I-seK! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@abhijeetnishal
Copy link
Owner

abhijeetnishal commented May 22, 2024

Great, Assigning this issue to you now.

You are implementing frontend and backend both right?
The UI should be responsive also right?

@Abh-I-seK
Copy link
Contributor Author

Great, Assigning this issue to you now.

You are implementing frontend and backend both right? The UI should be responsive also right?

Yes, I will implement both responsive frontend and backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants