Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array with nulls #12

Open
jean343 opened this issue Feb 26, 2018 · 0 comments
Open

Array with nulls #12

jean343 opened this issue Feb 26, 2018 · 0 comments

Comments

@jean343
Copy link

jean343 commented Feb 26, 2018

Hello,

Thanks for your fork, it helps me a lot!

I am having one issue with DeepExtend, it will merge arrays with null by removing the nulls.
For example, if we merge [{},null,{}] with itself, it will result in [{},{}], which is incorrect as the keys differs.

My proposed solution is to change the is_null to isUndefined in the array case of DeepExtend

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants