Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Type annotations #79

Open
abbbi opened this issue Nov 9, 2022 · 0 comments
Open

Finish Type annotations #79

abbbi opened this issue Nov 9, 2022 · 0 comments
Labels
code-cleanup help wanted Extra attention is welcome
Milestone
v2.0

Comments

@abbbi
Copy link
Owner

abbbi commented Nov 9, 2022 •
edited
Loading

Add python type annotations where possible, goal should be to have a clean mypy run. Some modules seem to lack
type stubs, such as libvirt and lz4, but most parts should be straight forward (only the the runtime try/catch fun with the functions using lxml would need quite some redesign [Found 151 errors in 5 files]). See linked branch for progress..
@abbbi abbbi added the enhancement New feature or request label Nov 9, 2022
@abbbi abbbi added this to the v2.0 milestone Nov 9, 2022
@abbbi abbbi added code-cleanup help wanted Extra attention is welcome and removed enhancement New feature or request help wanted Extra attention is welcome labels Nov 9, 2022
@abbbi abbbi changed the title Type annotations Finish Type annotations Nov 11, 2022
abbbi added a commit that referenced this issue Nov 11, 2022
@abbbi
(#79) first round of type annotations
72a4fe1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-cleanup help wanted Extra attention is welcome
Projects
None yet
Milestone
v2.0
Development

When branches are created from issues, their pull requests are automatically linked.

dev abbbi/virtnbdbackup
1 participant
@abbbi