Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5.1 Code-Signing Error on Mac Build? #95

Open
QuintillusCFC opened this issue Oct 4, 2022 · 3 comments
Open

3.5.1 Code-Signing Error on Mac Build? #95

QuintillusCFC opened this issue Oct 4, 2022 · 3 comments
Labels
not our bug Bugs from external software/configuration

Comments

@QuintillusCFC
Copy link

Hey all, this is a great CI image, our indie game team has been using it for many months now for our builds.

I recently switched the version to 3.5.1, and noticed that the Mac build fails, with this message:

ERROR: Code Signing: Ad-hoc signed applications require the 'Disable Library Validation' entitlement to load dynamic libraries.

The actual build we used is at https://github.com/C7-Game/Prototype/actions/runs/3171446928/jobs/5165435494 . It works as expected on 3.5 and 3.4.4 without any other changes.

It could be an upstream flag that was overlooked for 3.5.1 as well; I'm not well versed enough in Mac code signing to identify the root cause.

We'll probably jump from 3.5 to 3.5.2 since we aren't great about updating every release anyway, thought I should note it though in case others are running into the same issue.

@Calinou Calinou added the bug Something isn't working label Oct 4, 2022
@QuintillusCFC
Copy link
Author

FYI, upon further investigation this affects 3.5 (base, without the 3.5.1) on Mac too. We've kept our Mac build on 3.4.x for the time being.

@Calinou
Copy link
Collaborator

Calinou commented Oct 29, 2022

cc @bruvzg

@bruvzg
Copy link

bruvzg commented Oct 29, 2022

The error is correct, Mono and GDNative/GDExtension require this option to be enabled if you are using ad-hoc signature (in the export options, check CodesignEntitlementsDisable Library Validation).

  • 3.4.4 do not have ad-hoc signature support (if you did not set Apple Dev ID data, exported app won't be signed at all and won't be usable on Apple Silicon macs).
  • 3.5 added support for ad-hoc signing and have it enabled by default.
  • 4.0 also have ad-hoc signing supported and will auto enable Disable Library Validation if it's not set (probably should be backported for 3.6).

See https://docs.godotengine.org/en/latest/tutorials/export/running_on_macos.html, for more info about signing options.

@realkotob realkotob added not our bug Bugs from external software/configuration and removed bug Something isn't working labels Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not our bug Bugs from external software/configuration
Projects
None yet
Development

No branches or pull requests

4 participants