Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lambda function in api.py for better readability #9

Open
coderabbitai bot opened this issue Sep 27, 2024 · 2 comments
Open

Simplify lambda function in api.py for better readability #9

coderabbitai bot opened this issue Sep 27, 2024 · 2 comments

Comments

@coderabbitai
Copy link

coderabbitai bot commented Sep 27, 2024

As requested by @kirk0830, there is an opportunity to simplify the lambda function inside the list comprehension in . For more details, please refer to PR #93 and this comment.

@kirk0830
Copy link

after a refactor, the orbital generation code now supports both scipy.bfgs and various torch optimizer now, all optimizers sharing the same interface. the file api.py now only stores some util functions, so this issue is not valid anymore

@kirk0830
Copy link

@dyzheng could you check if you can close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant