Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid extracting element information from folder names #11

Open
coderabbitai bot opened this issue Oct 26, 2024 · 2 comments
Open

Avoid extracting element information from folder names #11

coderabbitai bot opened this issue Oct 26, 2024 · 2 comments

Comments

@coderabbitai
Copy link

coderabbitai bot commented Oct 26, 2024

As discussed in PR #103 at this comment, it's not a good practice to extract element information from folder names. We should refactor the code to avoid this.\n\nRequested by @kirk0830.

@kirk0830
Copy link

extracting information from the folder's name is stupid and less robust. In the future a fingerprint file will be used to identify the ABACUS job folder (due to there is developer still use the folder name to identify by eye). Presently the solution is not to hard-coding the folder name, but to use one function to care for the nomenclature. The function can provide a unified and stable, although temporary solution.

@kirk0830
Copy link

@dyzheng could you close this issue? Temporarily it is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant