Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] workflow download crowdin must be configure to run only on the original repo to avoid useless emailing #2278

Open
NandyBa opened this issue Dec 9, 2024 · 0 comments · May be fixed by #2279
Open

[Bug] workflow download crowdin must be configure to run only on the original repo to avoid useless emailing #2278

NandyBa opened this issue Dec 9, 2024 · 0 comments · May be fixed by #2279
Labels
bug Something isn't working new issue This issue has not been triaged by the core team yet

Comments

@NandyBa
Copy link
Contributor

NandyBa commented Dec 9, 2024 •
edited
Loading

Describe the bug
At ACI we have a intance of this repo to implement and test change before pushing then to Aave Lab
We detect that workflow "Download crowdin" was executed on all the fork resulting on GitHub action failed and useless minimum 4 email notifications a day

Can you add an if: github.repository == 'aave/interface' as described in this GitHub doc chapter

To Reproduce
Steps to reproduce the behavior:

  1. fork the repo
  2. push it to github
  3. wait some hour until the workflork "Download crowdin" been trigger by cron

Expected behavior
Workflow "Download crowdin" must been tigger only on the original repo

Screenshots
If applicable, add screenshots to help explain your problem.

Devices
All devices

Example of email
Capture d’écran 2024-12-09 à 21 41 40
@NandyBa NandyBa added bug Something isn't working new issue This issue has not been triaged by the core team yet labels Dec 9, 2024
NandyBa added a commit to AaveChan/aave-interface that referenced this issue Dec 9, 2024
@NandyBa
fix: run download crowdin only on original repo
d056de3 
avoid sending usuless failed email to fork contributors fix aave#2278
@NandyBa NandyBa linked a pull request Dec 9, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working new issue This issue has not been triaged by the core team yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: skip download crowdin files workflow on forks AaveChan/aave-interface
1 participant
@NandyBa