Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MarketWarning component #1344

Open
drewcook opened this issue Dec 1, 2022 · 1 comment
Open

Refactor MarketWarning component #1344

drewcook opened this issue Dec 1, 2022 · 1 comment
Labels
enhancement new issue This issue has not been triaged by the core team yet priority:low

Comments

@drewcook
Copy link
Contributor

drewcook commented Dec 1, 2022

Tech Debt

Refactor the <MarketWarning /> component to return an empty JSX tag when the network being passed in is not in a maintained 'frozen markets' list. Currently, in all theimplementations across the UI, there are additional checks against the market name on if it should be rendered or not. This logic should be, instead, moved and contained within the MarketWarning component itself.

Furthermore, consider renaming the component to FrozenMarketWarning, since that is what it is primarily doing. If there is ever a need to expand to other "global market-based warnings", then this component can be renamed back to MarketWarning and expanded upon.

@drewcook drewcook added feature New feature or request new issue This issue has not been triaged by the core team yet priority:low enhancement and removed feature New feature or request labels Dec 1, 2022
@drewcook drewcook reopened this Jan 12, 2023
@Jdecristi
Copy link
Contributor

@defispartan did you fix this in pr #1141?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new issue This issue has not been triaged by the core team yet priority:low
Projects
None yet
Development

No branches or pull requests

2 participants