From 5cefb60cfdf2ab999d60c6e0b4565b0040cccf01 Mon Sep 17 00:00:00 2001
From: CheyenneAtapour <CheyenneAtapour@gmail.com>
Date: Tue, 6 Aug 2024 18:19:23 -0700
Subject: [PATCH] fix: use internal constant for max borrow rate

---
 src/contracts/misc/GhoAaveSteward.sol | 5 +----
 src/test/TestGhoAaveSteward.t.sol     | 6 +++---
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/contracts/misc/GhoAaveSteward.sol b/src/contracts/misc/GhoAaveSteward.sol
index e9f026a9..4640d34d 100644
--- a/src/contracts/misc/GhoAaveSteward.sol
+++ b/src/contracts/misc/GhoAaveSteward.sol
@@ -257,12 +257,9 @@ contract GhoAaveSteward is RiskCouncilControlled, IGhoAaveSteward {
       'INVALID_VARIABLE_RATE_SLOPE2'
     );
 
-    uint256 maxBorrowRate = IDefaultInterestRateStrategyV2(
-      ghoReserveData.interestRateStrategyAddress
-    ).MAX_BORROW_RATE();
     require(
       uint256(baseVariableBorrowRate) + uint256(variableRateSlope1) + uint256(variableRateSlope2) <=
-        maxBorrowRate,
+        GHO_BORROW_RATE_MAX / 1e23,
       'BORROW_RATE_HIGHER_THAN_MAX'
     );
   }
diff --git a/src/test/TestGhoAaveSteward.t.sol b/src/test/TestGhoAaveSteward.t.sol
index 3bbedb53..ce9a69d8 100644
--- a/src/test/TestGhoAaveSteward.t.sol
+++ b/src/test/TestGhoAaveSteward.t.sol
@@ -54,7 +54,7 @@ contract TestGhoAaveSteward is TestGhoBase {
     update[0].asset = address(GHO_TOKEN);
     update[0].params = MockConfigEngine.InterestRateInputData({
       optimalUsageRatio: 1_00,
-      baseVariableBorrowRate: 0.25e4,
+      baseVariableBorrowRate: 0.20e4,
       variableRateSlope1: 0,
       variableRateSlope2: 0
     });
@@ -305,11 +305,11 @@ contract TestGhoAaveSteward is TestGhoBase {
     vm.prank(RISK_COUNCIL);
     GHO_AAVE_STEWARD.updateGhoBorrowRate(
       defaultRateParams.optimalUsageRatio,
-      0.26e4,
+      0.21e4,
       defaultRateParams.variableRateSlope1,
       defaultRateParams.variableRateSlope2
     );
-    assertEq(_getGhoBorrowRate(), 0.26e4);
+    assertEq(_getGhoBorrowRate(), 0.21e4);
   }
 
   function testUpdateGhoBorrowRateUpwards() public {