From 6c62128b9753bf3fb1bba6c280d05c35c6e3ed13 Mon Sep 17 00:00:00 2001 From: Nour Elrashidy Date: Wed, 4 Dec 2024 09:22:02 +0100 Subject: [PATCH] CCIP-4472: Update default rate limit and cleanup comments (#1558) ## Motivation [CCIP-4472](https://smartcontract-it.atlassian.net/browse/CCIP-4472) ## Solution --- core/services/ocr2/plugins/ccip/tokendata/lbtc/lbtc.go | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/core/services/ocr2/plugins/ccip/tokendata/lbtc/lbtc.go b/core/services/ocr2/plugins/ccip/tokendata/lbtc/lbtc.go index f7aad6ee94..0e36e7ae5b 100644 --- a/core/services/ocr2/plugins/ccip/tokendata/lbtc/lbtc.go +++ b/core/services/ocr2/plugins/ccip/tokendata/lbtc/lbtc.go @@ -21,7 +21,6 @@ import ( "github.com/smartcontractkit/chainlink/v2/core/services/ocr2/plugins/ccip/tokendata/http" ) -// TODO: double check the validty of default values for lombard's API after checking docs const ( apiVersion = "v1" attestationPath = "deposits/getByHash" @@ -35,8 +34,8 @@ const ( maxCoolDownDuration = 10 * time.Minute // defaultRequestInterval defines the rate in requests per second that the attestation API can be called. - // this is set according to the APIs documentated 10 requests per second rate limit. - defaultRequestInterval = 100 * time.Millisecond + // this is set according to the APIs recommended 5 requests per second rate limit. + defaultRequestInterval = 200 * time.Millisecond // APIIntervalRateLimitDisabled is a special value to disable the rate limiting. APIIntervalRateLimitDisabled = -1 @@ -74,10 +73,9 @@ type TokenDataReader struct { type messageAttestationResponse struct { MessageHash string `json:"message_hash"` Status attestationStatus `json:"status"` - Attestation string `json:"attestation"` // Attestation represented by abi.encode(payload, proof) + Attestation string `json:"attestation,omitempty"` // Attestation represented by abi.encode(payload, proof) } -// TODO: Adjust after checking API docs type attestationRequest struct { PayloadHashes []string `json:"messageHash"` } @@ -86,8 +84,6 @@ type attestationResponse struct { Attestations []messageAttestationResponse `json:"attestations"` } -// TODO: Implement encoding/decoding - type sourceTokenData struct { SourcePoolAddress []byte DestTokenAddress []byte