Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning with invalid confidence level #19

Open
VLDrenth opened this issue Jun 5, 2023 · 2 comments
Open

No warning with invalid confidence level #19

VLDrenth opened this issue Jun 5, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@VLDrenth
Copy link

VLDrenth commented Jun 5, 2023

There is no error or warning message shown when the confidence level is set outside 0 or 1. In this case the confidence level seen in the output (and exports) is set at 95%. It would probably be good to have a warning message when an invalid confidence level is selected.

@aalfons aalfons added the bug Something isn't working label Jun 9, 2023
@aalfons aalfons self-assigned this Jun 9, 2023
@aalfons
Copy link
Owner

aalfons commented Jun 9, 2023

The fix should be in two parts:

  1. Package robmed should show a warning in this case.
  2. The GUI should not allow to set the confidence level outside a reasonable range, for instance the interval [0.9, 1).

@aalfons
Copy link
Owner

aalfons commented Jun 9, 2023

Part 1. is now fixed in package robmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants