Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few issues #66

Open
prettydiff opened this issue May 14, 2023 · 1 comment
Open

A few issues #66

prettydiff opened this issue May 14, 2023 · 1 comment

Comments

@prettydiff
Copy link

prettydiff commented May 14, 2023

  • The output is JSON and contains a property version of type string that stores the ID3 tag version. The TypeScript definition file does not contain this property on type TagType.
  • Some few of my MP3 files output the ID3v1 genre index for a given recognized genre instead of the actual string. For example generating 36 instead of Game.
  • There were other cases (very few) where the genre could not be read at all. It can see the tag is there in the file TCON, but it supplies an empty string for the value.

I am currently laid off, so I have all the time in the world to provide any assistance and resources necessary to help correct these issues.

I may also might be able to help improve performance. I attempted to write an ID3 parser of my own and it is far less reliable than yours, but I was able to get through my 3680 files in about 1.45 seconds. It takes about 60 seconds to read the ID3 data using your library, which is slower but the output is so more reliable. If the problem is file system traversal I have a library I wrote that is very good as it can map these files in about 0.15 seconds.

@Zenaro
Copy link

Zenaro commented May 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants