-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image and text masks #22
Comments
This could be achieved as a style applied to any text block. This is a quick CodePen to show how it works |
@otakupahp, would you like to move forward and build this? Or would you need/want designs for the UI? |
@dhanson-wp I can do this.
Is it ok to create a Heading block variation? I don't think it will be useful for a Paragraph block
For this, I need a bit of explanation |
Heading Block variation makes the most sense. Shape masks similar to what is offered in this block plugin https://wpstackable.com/advanced-image-block/. Or this plugin here https://wordpress.org/plugins/wp-image-mask/ |
Got it. Please assign me this. I can't take it myself |
@otakupahp just assigned it to you. I don't believe there are UI designs for this feature. Are you okay building this without a design? |
Yes, I'll work on this and ask for feedback when needed |
Hi @dhanson-wp, I checked the https://wordpress.org/plugins/wp-image-mask/ plugin, and it adds the mask as an addition to the image block. I can either create a new block variation for the heading and image blocks or add the mask options via New block variations are a good idea to let the user know what to expect with the block, but adding features to custom blocks, let the users add masks to any image or heading without changing manually each block. Which path would you prefer? |
@otakupahp I'd like to allow @Nyiriland or another designer to offer their thoughts on this block. This issue was created from the original ideas document from Studio 51. I don't know if there are more details or functionality beyond that. |
The text was updated successfully, but these errors were encountered: