Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings using single quotes are not detected #16

Open
Zylann opened this issue Jun 19, 2020 · 0 comments
Open

Strings using single quotes are not detected #16

Zylann opened this issue Jun 19, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Zylann
Copy link
Owner

Zylann commented Jun 19, 2020

Only double quotes are considered by the extractor, because according to Python convention, they are the ones containing actual text. I also didn't think about single quotes since I never use them.
Despite all that, I've seen tr being used on single-quoted strings in GDScript inside other plugins, and these strings could be IDs.
These strings are either undetected, or cause extraction errors.

@Zylann Zylann added bug Something isn't working enhancement New feature or request labels Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant