From 492d1cc2be7ffbeed53fcf25bf6a2743f3fe9439 Mon Sep 17 00:00:00 2001 From: Niko Strijbol Date: Tue, 23 Apr 2019 00:06:05 +0200 Subject: [PATCH] Fix padding being too small above menu title --- .../java/be/ugent/zeus/hydra/common/ui/widgets/MenuTable.java | 3 +-- .../be/ugent/zeus/hydra/minerva/common/MinervaRequest.java | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/main/java/be/ugent/zeus/hydra/common/ui/widgets/MenuTable.java b/app/src/main/java/be/ugent/zeus/hydra/common/ui/widgets/MenuTable.java index 9124ea3ee..bdd8aa6e0 100644 --- a/app/src/main/java/be/ugent/zeus/hydra/common/ui/widgets/MenuTable.java +++ b/app/src/main/java/be/ugent/zeus/hydra/common/ui/widgets/MenuTable.java @@ -116,8 +116,7 @@ private void createText(String text, boolean isTitle, boolean isHtml) { } else { v.setTextAppearance(R.style.Subhead); } - textPaddingTop = rowPadding; - + textPaddingTop = getContext().getResources().getDimensionPixelSize(R.dimen.vertical_padding); } else if (messagePaddingTop) { textPaddingTop = getContext().getResources().getDimensionPixelSize(R.dimen.vertical_padding); } else { diff --git a/app/src/main/java/be/ugent/zeus/hydra/minerva/common/MinervaRequest.java b/app/src/main/java/be/ugent/zeus/hydra/minerva/common/MinervaRequest.java index 21e41c932..7d9fe2eb9 100644 --- a/app/src/main/java/be/ugent/zeus/hydra/minerva/common/MinervaRequest.java +++ b/app/src/main/java/be/ugent/zeus/hydra/minerva/common/MinervaRequest.java @@ -72,7 +72,6 @@ public Result execute(@NonNull Bundle args) { throw e; // Proceed with error. } - // TODO: log if this happens at all. // This should never be the case: // 1. If the access token is expired, the getToken() function will have caught and resolved it. // 2. If not resolvable, an AuthenticatorActionException will be thrown.